<Swing Dev> [8] Review request for 8015300: JComboBox text sometimes become selected, sometimes not (Windows LAF)

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Mon Jul 29 14:40:26 UTC 2013


On 7/26/2013 1:17 PM, sergey malenkov wrote:
> > Does the issue is applicable for the other components that use the 
> JTextField for the text typing?
>
> No, there are another approach is used.
> Note that editable ComboBox shows TextField always.

    The fix looks good for me.

     Please also check, that javax/swing/JComboBox tests passes with the 
fix and the the comboox editor always has parent.

    Thanks,
    Alexandr.

>
> SAM
>
> On 24.07.2013 18:18, Alexander Scherbatiy wrote:
>> On 7/24/2013 3:23 PM, sergey malenkov wrote:
>>> Hello,
>>>
>>> Could you please review the following fix:
>>> fix: http://cr.openjdk.java.net/~malenkov/8015300.8.0/ 
>>> <http://cr.openjdk.java.net/%7Emalenkov/8015300.8.0/>
>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015300
>>>
>>> The focus is not moved from JComboBox to its ComboBoxEditor,
>>> so we should check that one of these components is foxused.
>>>
>>     I am not an expert in the focus area. Does the issue is 
>> applicable for the other components that use the JTextField for the 
>> text typing?
>>
>>     Thanks,
>>     Alexandr.
>>
>>> Thanks,
>>> SAM
>>
>




More information about the swing-dev mailing list