<Swing Dev> [8] Review request for 7151823: The test incorrectly recognizing OS

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Mon Jun 3 09:52:15 UTC 2013


The fix looks good for me.

  Next time you could use hitMnemonics() method form the swing 
regtesthelpers Util class that uses system mnemonics keys.

  Thanks,
  Alexandr.


On 6/2/2013 1:30 PM, Anton Litvinov wrote:
> Hello,
>
> Please review the following fix for the bug.
>
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7151823
> Webrev: http://cr.openjdk.java.net/~alitvinov/7151823/webrev.00
>
> The bug consists in the fact that a regression test for the bug 
> 4624207 cannot define that it is being run on OS X platform, when Aqua 
> L&F is not used by Java. The fix substitutes detection of the platform 
> by analyzing L&F for usage of "sun.awt.OSInfo.getOSType()" method.
>
> Thank you,
> Anton




More information about the swing-dev mailing list