<Swing Dev> [7u] Review request for 8014863 Line break calculations in Java 7 are incorrect

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Mon Jun 3 14:19:05 UTC 2013


   The fix looks good for me.

   Thanks,
   Alexandr.

On 6/3/2013 4:09 PM, dmitry markov wrote:
> Hi Alexandr,
>
> I have just tested the fix. The tests are passed.
>
> Thanks,
> Dmitry
>
> On 03/06/2013 13:39, Alexander Scherbatiy wrote:
>>
>>
>>   Could you test your fix with the Notepad and Stylepad demos and run 
>> the regression tests:
>>     jdk\test\javax\swing\text
>>
>>    Thanks,
>>    Alexandr.
>>
>> On 6/3/2013 1:09 PM, dmitry markov wrote:
>>> Hello,
>>>
>>> Please review the back-port of the fix for 8014863 to jdk7u. I have 
>>> changed the fix for jdk7u, corrected the calculation of the variable 
>>> 'index1' to prevent an IndexOutOfBoundsException.
>>> New webrev is located at 
>>> http://cr.openjdk.java.net/~alitvinov/8014863/webrev.01
>>>
>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014863
>>> jdk8 changeset: 
>>> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c8a0abc1fd2d
>>> technical review for jdk8: 
>>> http://mail.openjdk.java.net/pipermail/swing-dev/2013-May/002709.html
>>>
>>> Thanks,
>>> Dmitry
>>>
>>> On 31/05/2013 12:53, dmitry markov wrote:
>>>> Hello,
>>>>
>>>> Please review the back-port of the fix for 8014863 to jdk7u. The 
>>>> changes are the same.
>>>>
>>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014863
>>>> webrev for jdk7u-dev: 
>>>> http://cr.openjdk.java.net/~vkarnauk/8014863/jdk7/webrev.00/
>>>> jdk8 changeset: 
>>>> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c8a0abc1fd2d
>>>> technical review for jdk8: 
>>>> http://mail.openjdk.java.net/pipermail/swing-dev/2013-May/002709.html
>>>>
>>>> Thanks,
>>>> Dmitry
>>>
>>
>




More information about the swing-dev mailing list