<Swing Dev> [8] Review request for 8013571: TreeModelEvent doesn't accept " null " for root as Javadoc specifies.

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Mon Jun 17 14:03:33 UTC 2013


   The fix looks good for me.

   Thanks,
   Alexandr.

On 6/17/2013 5:45 PM, sergey malenkov wrote:
>
> On 17.06.2013 15:29, Alexander Scherbatiy wrote:
>> On 6/14/2013 8:42 PM, sergey malenkov wrote:
>>> Could you please review the following fix:
>>> fix: http://cr.openjdk.java.net/~malenkov/8013571.8.0 
>>> <http://cr.openjdk.java.net/%7Emalenkov/8013571.8.0/>
>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013571
>>
>>    It is better to move the "TreePath getTreePath(TreeModelEvent 
>> event)"  method to sun.swing.SwingUtilities2 class.
>
> Could you please review the second version of the fix:
> http://cr.openjdk.java.net/~malenkov/8013571.8.1 
> <http://cr.openjdk.java.net/%7Emalenkov/8013571.8.1/>
> I moved the getTreePath method to the SwingUtilities2 class
> with needed changes in it.
>
> Thanks,
> SAM




More information about the swing-dev mailing list