<Swing Dev> [8] Review request for 7163696: JCK Swing interactive test JScrollBarTest0013 fails with Nimbus and GTK L&Fs

[Sergey Malenkov]

Hi Alexander,

 > The bar variable in the test is used on both threads main and EDT
 > and so need to have synchronization or be declared as volatile.

The synchronization is not needed, because there is invokeAndWait() 
call, but it is a good idea to declare the field as volatile.

 > Why error should not be reported during manual testing?

It is useful to debug, because the window is not disposed.

Thanks,
SAM

On 01.03.2013 16:22, Alexander Scherbatiy wrote:
> On 3/1/2013 2:52 PM, Sergey Malenkov wrote:
>> Hello,
>>
>> Could you please review the following fix:
>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7163696
>> fix: http://cr.openjdk.java.net/~malenkov/7163696.0/
>>
>> There is a missed super.installDefaults() call in SynthScrollBarUI.
>
>      The bar variable in the test is used on both threads main and EDT
> and so need to have synchronization or be declared as volatile.
>      Why error should not be reported during manual testing?
>
>     Thanks,
>     Alexandr.
>
>>
>> Thanks,
>> SAM