<Swing Dev> [8] Request for review: 8000435: [macosx] Button painting error under Java 7 on Mac

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Wed Mar 13 12:41:35 UTC 2013


   The fix looks good for me.

   Is it possible to write a test on it?

   Thanks,
   Alexandr.

On 3/12/2013 9:56 PM, Sergey Bylokhov wrote:
> Hello,
> Please review the fix for jdk 8. Fix will be ported to jdk7 as well.
> This is a tweak of the code which mimic some macosx constant.
> The problem was in the assumption that we can paint native buttons 
> with the height of >=18 pixel(28 - 5 - 5 ), but currently it should be 
> >=24(28 - 2 - 2).
>
> In AquaButtonExtendedTypes constants in alterInsets() were changed to 
> be less strict.
> http://cr.openjdk.java.net/~serb/8000435/before_segmentedRoundRect_first_small.png 
>
> http://cr.openjdk.java.net/~serb/8000435/after_segmentedRoundRect_first_small.png 
>
>
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000435
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/8000435/webrev.00/
>




More information about the swing-dev mailing list