<Swing Dev> Rejected: [8] Review request for CR 8009880 TEST_BUG: Test java/beans/Introspector/TestTypeResolver.java should be modified again

Sergey Malenkov Sergey.Malenkov at oracle.com
Wed Mar 20 07:06:31 UTC 2013


Hi Konstantin,

There are a lot of unnecessary changes in your fix.  They make it 
difficult to analyze changes in the future.  Could you please prepare a 
new webrev with the needed changes only?

For example:
http://hg.openjdk.java.net/jdk8/jdk8/jdk/diff/a51777c9228a/test/java/beans/Introspector/TestTypeResolver.java
http://hg.openjdk.java.net/jdk8/jdk8/jdk/diff/32721a1a8da8/test/java/beans/Introspector/TestTypeResolver.java

Thanks,
SAM

On 19.03.2013 18:23, Konstantin Shefov wrote:
> Hello,
>
> Please review a fix for the issue:
>
> 8009880 TEST_BUG: Test java/beans/Introspector/TestTypeResolver.java
> should be modified again
>
> The webrev is: http://cr.openjdk.java.net/~kshefov/8009880/webrev.00/
>
> Added necessary method declarations for successful test compilation:
>
>   218         @Override
>   219         public AnnotatedType[] getAnnotatedBounds() {
>   220             return null; // not used
>   221         }
>   222
>   223         @Override
>   224         public <T extends Annotation> T[]
> getAnnotationsByType(Class<T> annotationClass) {
>   225             return null; // not used
>   226         }
>   227
>   228         @Override
>   229         public <T extends Annotation> T[]
> getDeclaredAnnotationsByType(Class<T> annotationClass) {
>   230             return null; // not used
>   231         }
>
> Thanks,
> Konstantin



More information about the swing-dev mailing list