<Swing Dev> RFR Doclint cleanup of javax.swing

roger riggs roger.riggs at oracle.com
Fri Nov 8 14:53:12 UTC 2013


Hi Alexandr,

I'll fixup these cases,  the bulk of the changes were generated from a 
script/program
that focused on the bad markup. Including the longer literal reduces the 
interruption
when reading.

Thanks, Roger

On 11/8/2013 5:40 AM, Alexander Scherbatiy wrote:
>
> Could you include the bug id to the subject like:  [8] Review request 
> for BugID Bug title.
>
> AbstractButton.java
> -     * @exception   IllegalArgumentException if threshhold < 0
> +     * @exception   IllegalArgumentException if threshhold {@literal 
> > 0}
>
> JMenu.java
> -     *                  <code>pos</code> < 0
> +     *                  <code>pos</code> {@literal > 0}
>
> It seems that right condition should be {@literal < 0}.
>
> In some places a whole operator is included in to the literal like 
> "View (JTable) {@literal ->} model."
> In others places only part of an operator is included "0.0f -{@literal 
> >} 1.0f"
> May be it is better to use an uniform style for all cases.
>
> Thanks,
> Alexandr.
>
>
> On 11/8/2013 2:02 AM, roger riggs wrote:
>> This changeset addresses the warnings and errors of doclint and
>> improves the quality of the generated html.
>> No spec or implementation is changed by this changeset
>>
>> The changes address issues including html syntax, accessibility issues,
>> and improper html tag use. Refer to the error log attached to the bug 
>> report [1] for details.
>>
>> Please review:
>>    http://cr.openjdk.java.net/~rriggs/webrev-lint-swing-8028018/
>>
>> Thanks, Roger
>>
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8028018
>




More information about the swing-dev mailing list