<Swing Dev> [8] Review request for 8028054: com.sun.beans.finder.MethodFinder has unsynchronized access to a static Map

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Fri Nov 22 12:50:03 UTC 2013


Hi, Sergey.
The fix looks good.

On 14.11.2013 17:50, sergey malenkov wrote:
>
> Hello,
>
> Could you please review the following fix:
> fix: http://cr.openjdk.java.net/~malenkov/8028054.8.0/
> bug: https://bugs.openjdk.java.net/browse/JDK-8028054
>
> There is an unsynchronized access to internal caches.
> I've synchronized both caches (for methods and constructors) .
>
> The 8023310 issue shows how is slow a simple synchronization.
> So I've created the Cache class that is similar to WeakIdentityMap.
> Later we could remove WeakIdentityMap which is a special case of Cache.
>
> Thanks,
> SAM
>


-- 
Best regards, Sergey.




More information about the swing-dev mailing list