<Swing Dev> [8] Review Request: 8029010 [macosx] Need test for JDK-7124513
Petr Pchelko
petr.pchelko at oracle.com
Fri Nov 29 10:10:13 UTC 2013
Hello, Sergey.
The fix looks good, just 2 tiny comments:
line 64: you have a typo: shuould
line 65: testImages(images[1], images[1], false) - I believe this is also a typo, you are comparing the same images, so the second 1 should be changed to 2.
With best regards. Petr.
On 28.11.2013, at 17:52, Alexander Scherbatiy <alexandr.scherbatiy at oracle.com> wrote:
>
> The fix looks good for me.
>
> Thanks,
> Alexandr.
>
> On 11/28/2013 4:56 PM, Sergey Bylokhov wrote:
>> Hello.
>> Please review the fix for jdk 8.
>> The test is for "apple.awt.brushMetalLook" and "Window.style", which were added in the JDK-7124513
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8029010
>> Webrev can be found at: http://cr.openjdk.java.net/~serb/8029010/webrev.00
>>
>
More information about the swing-dev
mailing list