<Swing Dev> Approved: [8] Review request for 8005391 Floating behavior of HTMLEditorKit parser

sergey malenkov sergey.malenkov at oracle.com
Tue Oct 8 15:18:26 UTC 2013


The fix looks good.

Thanks,
SAM

On 08.10.2013 14:57, Alexander Scherbatiy wrote:
> Hello,
>
> Could you review the fix:
>   bug: https://bugs.openjdk.java.net/browse/JDK-8005391
>   webrev: http://cr.openjdk.java.net/~alexsch/8005391/webrev.00
>
> The test in the webrev fails because SimpleAttributeSet returns 
> attribute names as Hashtable keys which order is not preserved.
> So the tags are also generated in the random order.
>
> The suggested fix uses LinkedHashMap instead of Hashtable which 
> guarantee predictable iteration order.
>
> The LinkedHashMap implementation is not synchronized as it is done for 
> the Hashtable.
> However, the SimpleAttributeSet is designed to use on EDT like others 
> swing classes.
>
> Thanks,
> Alexandr.
>




More information about the swing-dev mailing list