<Swing Dev> Approved: [8] Review request for 8020708 NLS: mnemonics missing in SwingSet2/JInternalFrame demo

sergey malenkov sergey.malenkov at oracle.com
Fri Oct 11 10:46:59 UTC 2013


The fix looks good to me.

SAM

On 11.10.2013 14:34, Alexander Scherbatiy wrote:
> On 10/10/2013 11:12 PM, Leonid Romanov wrote:
>> Hello,
>> Who is the author of localized properties changes? Is it you or 
>> someone from i18n team?
>
>     I have updated the localized InternalFrameTitlePane properties. 
> Only mnemonics have been updated.
>     It is done in the same way as for other properties like:
>       basic.properties: ColorChooser.rgbRed.textAndMnemonic=Re&d
>       basic_zh_TW.properties: 
> ColorChooser.rgbRed.textAndMnemonic=\u7D05(&D)
>
>    This is the standard procedure to include mnemonics into properties 
> by & sign.
>    So name=A&BC property means that the value is  ABC and the mnemonic 
> is B.
>    If a value does not contain a mnemonic char it needs to be added at 
> the end like  name=ABC(&D)
>
>     Thanks,
>     Alexandr.
>
>>
>> On Oct 10, 2013, at 7:00 PM, Alexander Scherbatiy 
>> <alexandr.scherbatiy at oracle.com> wrote:
>>
>>> Hello,
>>>
>>> Could you review the fix:
>>>   bug: https://bugs.openjdk.java.net/browse/JDK-8020708
>>>   webrev: http://cr.openjdk.java.net/~alexsch/8020708/webrev.00
>>>
>>>   The fix updates mnemonics for the InternalFrameTitlePane.*Button 
>>> properties
>>>   - Mnemonics are loaded from the *.properties files
>>>   - (&Mnemonic) is added for the localized text that does not 
>>> contains the mnemonics char
>>>
>>>
>>> Thanks,
>>> Alexandr.
>>>
>




More information about the swing-dev mailing list