<Swing Dev> Reminder: [8] Review request for CR 8006087 [TEST_BUG] The BACKSPACE key doesn't work and after pressing 'cancel' and 'DONE' button, the case pass automatically.
sergey malenkov
sergey.malenkov at oracle.com
Fri Sep 13 09:43:35 UTC 2013
I do not think that the fix is correct.
SAM
On 24.07.2013 19:14, sergey malenkov wrote:
> Hi Konstantin,
>
> Why you moved the JavaTest header to the HTML file?
> Almost all regression tests use a Java file for it.
> I think you should leave it "as is".
>
> Note that other HTML files in the test/javax/swing folder
> does not have the Oracle Copyright text.
> I'm not sure that we should add it into this file only.
>
> Other changes in your fix looks good for me.
>
> Thanks,
> SAM
>
> On 19.06.2013 14:01, Konstantin Shefov wrote:
>> Hello,
>>
>> Please review a fix for the issue:
>>
>> 8006087 [TEST_BUG] The BACKSPACE key doesn't work and after pressing
>> 'cancel' and 'DONE' button, the case pass automatically.
>>
>> Test bug fix.
>>
>> http://bugs.sun.com/view_bug.do?bug_id=8006087
>>
>> The webrev is: http://cr.openjdk.java.net/~kshefov/8006087/webrev.00
>>
>> Thanks,
>> Konstantin
>
More information about the swing-dev
mailing list