<Swing Dev> [8] Review request for CR 8015597 [TEST_BUG] [macosx] Test closed/javax/swing/JMenuBar/4750590/bug4750590.java fails since JDK 8 b75 on MacOSX

[Alexander Scherbatiy]

On 9/13/2013 2:29 PM, Konstantin Shefov wrote:
> Thanks, http://cr.openjdk.java.net/~kshefov/8015597/webrev.01

    - It is better to make the passed variable volatile because it is 
used on both EDT and main threads
    - It is not necessary to rethrow the robot exception
    - Usually the system out is not included into jtreg test. The jtreg 
either passes the test or fails it because of the exception/timeout etc.

   Thanks,
   Alexandr.

> On 13-Sep-13 14:25, Sergey Bylokhov wrote:
>> Hi, Konstantin.
>> You forgot about license.
>>
>> On 13.09.2013 14:21, Konstantin Shefov wrote:
>>> Hello,
>>>
>>> Please review a fix for the issue:
>>>
>>> 8015597 [TEST_BUG] [macosx] Test 
>>> closed/javax/swing/JMenuBar/4750590/bug4750590.java fails since JDK 
>>> 8 b75 on MacOSX
>>>
>>> Test bug fix. Move from closed repo.
>>>
>>> http://bugs.sun.com/view_bug.do?bug_id=8015597
>>>
>>> The webrev is: http://cr.openjdk.java.net/~kshefov/8015597/webrev.00 
>>> - add to open repo.
>>> http://cr.openjdk.java.net/~kshefov/8015597/webrev.diff - diff with 
>>> previous version of the test.
>>>
>>> Thanks,
>>> Konstantin
>>
>>
>