<Swing Dev> [8] Review request for CR 8006087 [TEST_BUG] The BACKSPACE key doesn't work and after pressing 'cancel' and 'DONE' button, the case pass automatically.

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Fri Sep 13 12:43:04 UTC 2013


Hi, Konstantin.
The fix looks good.

On 13.09.2013 14:57, Konstantin Shefov wrote:
> http://cr.openjdk.java.net/~kshefov/8006087/webrev.01
> On 13-Sep-13 14:05, Konstantin Shefov wrote:
>> I see, thanks, I will correct.
>>
>> On 13-Sep-13 14:04, Sergey Bylokhov wrote:
>>> I mean osx, since in the CR I see "test works fine with Metal LaF".
>>>
>>> On 13.09.2013 14:01, Konstantin Shefov wrote:
>>>> Hi, Sergey,
>>>> I do not think so, because the following comment from 
>>>> https://bugs.openjdk.java.net/browse/JDK-4150029:
>>>> Justification by: leif Date: 2001-06-07 Priority from 4 to 3:
>>>> Important compatibility issue for Windows L&F.
>>>>
>>>> On 13-Sep-13 13:56, Sergey Bylokhov wrote:
>>>>> Hi, Konstantin.
>>>>> Probably it will be better just change l&f to metal?
>>>>>
>>>>> On 13.09.2013 12:36, Konstantin Shefov wrote:
>>>>>> Please, review the fix below
>>>>>>
>>>>>> On 19-Jun-13 18:17, Alexandr Scherbatiy wrote:
>>>>>>> The fix looks good for me.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Alexandr.
>>>>>>>
>>>>>>> 19.06.2013 14:01, Konstantin Shefov пишет:
>>>>>>>> Hello,
>>>>>>>>
>>>>>>>> Please review a fix for the issue:
>>>>>>>>
>>>>>>>> 8006087 [TEST_BUG] The BACKSPACE key doesn't work and after 
>>>>>>>> pressing 'cancel' and 'DONE' button, the case pass automatically.
>>>>>>>>
>>>>>>>> Test bug fix.
>>>>>>>>
>>>>>>>> http://bugs.sun.com/view_bug.do?bug_id=8006087
>>>>>>>>
>>>>>>>> The webrev is: 
>>>>>>>> http://cr.openjdk.java.net/~kshefov/8006087/webrev.00
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Konstantin
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>> -- 
>>> Best regards, Sergey.
>>
>


-- 
Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20130913/421a2c6a/attachment.html>


More information about the swing-dev mailing list