<Swing Dev> [8] Review request for CR 8015601 [TEST_BUG] [macosx] Test javax/swing/JInternalFrame/InternalFrameIsNotCollectedTest.java fails on MacOS X

[Alexander Scherbatiy]

   The fix looks good for me.

   Thanks,
   Alexandr.

On 9/13/2013 5:14 PM, mikhail cherkasov wrote:
> Hi Alexander,
>
> There's new version 
> http://cr.openjdk.java.net/~mcherkas/8015601/webrev.01/ 
> <http://cr.openjdk.java.net/%7Emcherkas/8015601/webrev.01/>
> Thank you for your remarks.
>
> Thanks,
> Mikhail.
>
> On 13.09.2013 16:31, Alexander Scherbatiy wrote:
>> On 9/13/2013 3:28 PM, mikhail cherkasov wrote:
>>> Hello all,
>>>
>>> Please review a fix for the issue:
>>> 8015601 [TEST_BUG] [macosx] Test 
>>> javax/swing/JInternalFrame/InternalFrameIsNotCollectedTest.java 
>>> fails on MacOS X
>>> http://bugs.sun.com/view_bug.do?bug_id=8015601
>>> The test was fixed.
>>>
>>> Webrev: http://cr.openjdk.java.net/~mcherkas/8015601/webrev.00/ 
>>> <http://cr.openjdk.java.net/%7Emcherkas/8015601/webrev.00/>
>>
>>     - It is better to use OSInfo to get the OS name
>>     - Usually it is not reliable to use absolute coordinates like p.x 
>> + 25. May be it is possible to add a shortcut to the frame on MacOSX 
>> which can close the app.
>>
>>     Thanks,
>>     Alexandr.
>>>
>>> Thanks,
>>> Mikhail
>>>
>>
>