<Swing Dev> [8] Review request for CR 8017180: [macosx] [TEST_BUG] alt-key doesn't work on macos for menu

vera akulova vera.akulova at oracle.com
Thu Sep 19 16:09:37 UTC 2013


Hello,

please review updated fix: 
http://cr.openjdk.java.net/~kshefov/8017180/webrev.01/ 
<http://cr.openjdk.java.net/%7Ekshefov/8017180/webrev.01/>
added using of hitMnemonics, removed init, start methods

Thanks,
Vera

13.09.2013 17:02, Alexander Scherbatiy пишет:
> On 9/13/2013 4:11 PM, vera akulova wrote:
>> Hello,
>>
>> Please review a fix for the issue:
>> JDK-8017180 <https://bugs.openjdk.java.net/browse/JDK-8017180>: 
>> [macosx] [TEST_BUG] alt-key doesn't work on macos for menu
>>
>> The webrev is http://cr.openjdk.java.net/~kshefov/8017180/webrev.00/
>>
>> The fix automates tests and sets keys to press depending on the system.
>
>    - Util class contains hitMnemonics() method that uses system 
> depended key codes.
>    - init method can be converted to constructor.
>
>    Otherwise, the fix looks good for me.
>
>    Thanks,
>    Alexandr.
>
>>
>> Tests are moved from closed repo, diff with previous version of the 
>> test: http://cr.openjdk.java.net/~kshefov/8017180/webrev.diff/
>>
>> Thanks,
>> Vera. 
>




More information about the swing-dev mailing list