<Swing Dev> [8] Review request for JDK-7133146: [macosx] closed/javax/swing/JInternalFrame/4193219/IconCoord fails on MacOS

[Sergey Bylokhov]

Hi, Vera.
looks like in this version you forgot about license.

On 19.09.2013 20:05, vera akulova wrote:
> Hello,
>
> please review the new version of the fix: 
> http://cr.openjdk.java.net/~kshefov/7133146/webrev.02/ 
> <http://cr.openjdk.java.net/%7Ekshefov/7133146/webrev.02/>
>
> Thanks,
> Vera
>
> 13.09.2013 16:58, Sergey Bylokhov пишет:
>> Hi ,Vera.
>> Throw an exception in the init() isn't enough? Why you need 
>> additional dialog?
>>
>> On 05.02.2013 19:41, vera akulova wrote:
>>> Hi Sergey,
>>>
>>> On 25.12.2012 15:30, Sergey Bylokhov wrote:
>>>> Hi, Vera.
>>>> 25.12.2012 13:58, vera akulova wrote:
>>>>> Hello Sergey,
>>>>> Could you please review this fix?
>>>> I guess this code is incorrect
>>>>
>>>>   57         } catch (Exception ex) {
>>>>   58             System.err.println("Test failed: ");
>>>>   59             ex.printStackTrace();
>>>>   60         }
>>>>
>>> yes, thank you, could you please review updated fix:
>>> http://cr.openjdk.java.net/~kshefov/7133146/webrev.01/
>>>
>>> Thanks,
>>> Vera
>>>>
>>>>>
>>>>> Thanks,
>>>>> Vera
>>>>>
>>>>> On 11.12.2012 19:55, vera akulova wrote:
>>>>>> Hello,
>>>>>>
>>>>>> Please review a fix for the issue:
>>>>>>    JDK-7133146: [macosx] 
>>>>>> closed/javax/swing/JInternalFrame/4193219/IconCoord fails on MacOS
>>>>>>
>>>>>> The webrev is http://cr.openjdk.java.net/~kshefov/7133146/webrev.00/
>>>>>>
>>>>>> Metal L&F is used now. Fixed test works fine on windows, linux, 
>>>>>> solaris and macos.
>>>>>>
>>>>>> Thanks,
>>>>>> Vera.
>>>>
>>>>
>>>
>>
>>
>


-- 
Best regards, Sergey.