<Swing Dev> [8] Review request for CR 8015600 [TEST_BUG] [macosx] Test closed/javax/swing/plaf/basic/BasicMenuUI/4983388/bug4983388.java fails since JDK 8 b75 on MacOSX
Sergey Bylokhov
Sergey.Bylokhov at oracle.com
Mon Sep 23 10:42:28 UTC 2013
Hi, Konstantin.
The fix looks good.
On 23.09.2013 14:38, Konstantin Shefov wrote:
> Please, review the new version:
> http://cr.openjdk.java.net/~kshefov/8015600/webrev.02
>
> On 20-Sep-13 20:22, Sergey Bylokhov wrote:
>> Hi, Konstantin.
>> Probably it would be better, use default l&f if gtk is not supported?
>> Like it was before the fix?
>> Util.hitMnemonics(robot, KeyEvent.VK_F); should work on all l&f?
>>
>> On 20.09.2013 19:59, Konstantin Shefov wrote:
>>> http://cr.openjdk.java.net/~kshefov/8015600/webrev.01
>>> http://cr.openjdk.java.net/~kshefov/8015600/webrev.diff
>>>
>>> On 13-Sep-13 17:47, Sergey Bylokhov wrote:
>>>> Hi, Konstanti.
>>>> GTKLookAndFeel is not supported on windows as well.
>>>>
>>>> On 13.09.2013 17:41, Konstantin Shefov wrote:
>>>>> Hello,
>>>>>
>>>>> Please review a fix for the issue:
>>>>>
>>>>> 8015600 [TEST_BUG] [macosx] Test
>>>>> closed/javax/swing/plaf/basic/BasicMenuUI/4983388/bug4983388.java
>>>>> fails since JDK 8 b75 on MacOSX
>>>>>
>>>>> Test bug fix. Move from closed repo.
>>>>>
>>>>> http://bugs.sun.com/view_bug.do?bug_id=8015600
>>>>>
>>>>> The webrev is:
>>>>> http://cr.openjdk.java.net/~kshefov/8015600/webrev.00 - add to
>>>>> open repo.
>>>>> http://cr.openjdk.java.net/~kshefov/8015600/webrev.diff - diff
>>>>> with previous version of the test.
>>>>>
>>>>> Thanks,
>>>>> Konstantin
>>>>
>>>>
>>>
>>
>>
>
--
Best regards, Sergey.
More information about the swing-dev
mailing list