<Swing Dev> [8] Review Request: JDK-8025234 [javadoc] fix some errors in javax.swing.**

Dmitry Ginzburg dmitry.ginzburg at oracle.com
Fri Sep 27 10:48:14 UTC 2013


According to w3c (http://dev.w3.org/html5/markup/p.html#p) 
<http://dev.w3.org/html5/markup/p.html#p> pelement’send tagmay be 
omitted if thepelement is immediately followed by an <set of some tags>, 
but that's false in our case, it's followed by text.

27.09.2013 14:38, Sergey Bylokhov wrote:
> Why not just <p>?
>
> On 27.09.2013 14:32, Dmitry Ginzburg wrote:
>> If it made sense earlier to do the same thing with self-closing tag, 
>> it's now the same, but valid for doclint.
>>
>> 27.09.2013 14:30, Alexander Scherbatiy wrote:
>>>
>>> --- old/src/share/classes/javax/swing/AbstractButton.java
>>> +++ new/src/share/classes/javax/swing/AbstractButton.java
>>> @@ -1381,7 +1381,7 @@
>>>       * If <code>true</code> and the button has a border,
>>>       * the border is painted. The default value for the
>>>       * <code>borderPainted</code> property is <code>true</code>.
>>> -     * <p/>
>>> +     * <p></p>
>>>
>>>
>>> Does it has sense to have open and closed p tags without the text?
>>>
>>> Otherwise, the fix looks good for me.
>>>
>>> Thanks,
>>> Alexandr.
>>>
>>>
>>> On 9/26/2013 6:20 PM, Dmitry Ginzburg wrote:
>>>> Hello, Swing Team.
>>>>
>>>> Please review the fix for the following issue:
>>>> https://bugs.openjdk.java.net/browse/JDK-8025234
>>>> The fix is available at:
>>>> http://cr.openjdk.java.net/~yan/jdk-8025234/webrev.00/
>>>>
>>>> This is the fix for javadoc errors, on which doclint was showing 
>>>> some issues.
>>>>
>>>> The patch contains only simple markup fixes; no changes/fixes in
>>>> documentation text; the specification itself wasn't changed.
>>>>
>>>> Thanks,
>>>> -Dmitry 
>
>


-- 
Dmitry Ginzburg, FXSQE team member

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20130927/1dc205b0/attachment.html>


More information about the swing-dev mailing list