<Swing Dev> <AWT Dev> [8] Review request for 8020688: broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index.

[Anthony Petrov]

Thanks. I skimmed through the changes and they look good generally. A 
couple of nits:

src/share/classes/java/awt/event/ActionListener.java
> - * @see <a href="http://java.sun.com/docs/books/tutorial/post1.0/ui/eventmodel.html">Tutorial: Java 1.1 Event Model</a>

You're only removing the link here. You should add a new one, too, I guess.


src/share/classes/sun/text/normalizer/UCharacter.java
> - * <a href="http://java.sun.com/j2se/1.5/docs/api/java/lang/Character.html">
> + * <a href="http://docs.oracle.com/javase/1.5.0/docs/api/java/lang/Character.html">
>   * java.lang.Character</a> class. These extensions provide support for

I believe the <a> here should be replaced with a usual javadoc's {@link 
...} kind of thing.

--
best regards,
Anthony

On 09/27/2013 04:50 PM, mikhail cherkasov wrote:
> Hi Anthony,
>
> Please review a new version:
> http://cr.openjdk.java.net/~mcherkas/8020688/webrev.02/
> <http://cr.openjdk.java.net/%7Emcherkas/8020688/webrev.02/>
> I rely on http redirect, but it doesn't always work correctly. Now I
> re-checked all links.
>
> Thanks,
> Mikhail.
>
> On 27.09.2013 12:42, Anthony Petrov wrote:
>> Hi Mikhail,
>>
>> Please comment on the following:
>>
>> src/share/classes/java/awt/Component.java:
>>> - * <a
>>> href="http://java.sun.com/products/jfc/tsc/articles/painting/index.html">Painting
>>> in AWT and Swing</a>.
>>> + * <a
>>> href="http://www.oracle.com/technetwork/java/index.html">Painting in
>>> AWT and Swing</a>.
>>
>> The new link doesn't point to the "Painting..." article (and it is a
>> very good article, btw). Could you please check all the new links and
>> update the webrev?
>>
>> --
>> best regards,
>> Anthony
>>
>> On 09/26/2013 02:27 AM, mikhail cherkasov wrote:
>>> a new webrev: http://cr.openjdk.java.net/~mcherkas/8020688/webrev.01/
>>> <http://cr.openjdk.java.net/%7Emcherkas/8020688/webrev.01/>
>>> no changes, I've turned off laptop before the webrev upload was
>>> complete, so
>>> the first could be corrupted.
>>>
>>> On 25.09.2013 23:29, mikhail cherkasov wrote:
>>>> Hi all,
>>>>
>>>> Could you please review the fix for the following bug:
>>>> 8020688: broken links in documentation at
>>>> http://docs.oracle.com/javase/6/docs/api/index.
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8020688
>>>> The webrev: http://cr.openjdk.java.net/~mcherkas/8020688/webrev.00/
>>>> <http://cr.openjdk.java.net/%7Emcherkas/8020688/webrev.00/>
>>>>
>>>> Thanks,
>>>> Mikhail.
>>>
>