<Swing Dev> <AWT Dev> [8] Review request for 8020688: broken links in documentation at http://docs.oracle.com/javase/6/docs/api/index.

[mikhail cherkasov]

Anthony thank you for this link, it's good replacement for removed link.

Also I didn't find replacement for :
- * Also see the article <a 
href="http://java.sun.com/products/jfc/tsc/tech_topics/jlist_1/jlist.html">Advanced 
JList Programming</a>
- * in <a href="http://java.sun.com/products/jfc/tsc"><em>The Swing 
Connection</em></a>.

Do you have any suggestion about this link? the link to swing tutorial 
already are there:
http://docs.oracle.com/javase/tutorial/uiswing/components/list.html

Thanks,
Mikhail.

On 27.09.2013 18:31, Anthony Petrov wrote:
> On 09/27/2013 06:19 PM, mikhail cherkasov wrote:
>> Anthony, some links, like this one, we lost for ever.
>
> How about 
> http://docs.oracle.com/javase/tutorial/uiswing/events/actionlistener.html 
> ?
>
>
>> On 27.09.2013 18:12, Anthony Petrov wrote:
>>> Thanks. I skimmed through the changes and they look good generally. A
>>> couple of nits:
>>>
>>> src/share/classes/java/awt/event/ActionListener.java
>>>> - * @see <a
>>>> href="http://java.sun.com/docs/books/tutorial/post1.0/ui/eventmodel.html">Tutorial: 
>>>>
>>>> Java 1.1 Event Model</a>
>>>
>>> You're only removing the link here. You should add a new one, too, I
>>> guess.
>>>
>>>
>>> src/share/classes/sun/text/normalizer/UCharacter.java
>>>> - * <a
>>>> href="http://java.sun.com/j2se/1.5/docs/api/java/lang/Character.html">
>>>> + * <a
>>>> href="http://docs.oracle.com/javase/1.5.0/docs/api/java/lang/Character.html"> 
>>>>
>>>>
>>>>   * java.lang.Character</a> class. These extensions provide support 
>>>> for
>>>
>>> I believe the <a> here should be replaced with a usual javadoc's
>>> {@link ...} kind of thing.
>> Agree, and this should be done in all places, but this will be too much
>> changes for this fix.
>
> Certainly, we shouldn't change all and every occurrence of this. 
> However, this line is updated in your fix anyway, so why not apply the 
> correct pattern just for this particular case now?
>
> -- 
> best regards,
> Anthony
>
>
>>>
>>> -- 
>>> best regards,
>>> Anthony
>>>
>>> On 09/27/2013 04:50 PM, mikhail cherkasov wrote:
>>>> Hi Anthony,
>>>>
>>>> Please review a new version:
>>>> http://cr.openjdk.java.net/~mcherkas/8020688/webrev.02/
>>>> <http://cr.openjdk.java.net/%7Emcherkas/8020688/webrev.02/>
>>>> I rely on http redirect, but it doesn't always work correctly. Now I
>>>> re-checked all links.
>>>>
>>>> Thanks,
>>>> Mikhail.
>>>>
>>>> On 27.09.2013 12:42, Anthony Petrov wrote:
>>>>> Hi Mikhail,
>>>>>
>>>>> Please comment on the following:
>>>>>
>>>>> src/share/classes/java/awt/Component.java:
>>>>>> - * <a
>>>>>> href="http://java.sun.com/products/jfc/tsc/articles/painting/index.html">Painting 
>>>>>>
>>>>>>
>>>>>> in AWT and Swing</a>.
>>>>>> + * <a
>>>>>> href="http://www.oracle.com/technetwork/java/index.html">Painting in
>>>>>> AWT and Swing</a>.
>>>>>
>>>>> The new link doesn't point to the "Painting..." article (and it is a
>>>>> very good article, btw). Could you please check all the new links and
>>>>> update the webrev?
>>>>>
>>>>> -- 
>>>>> best regards,
>>>>> Anthony
>>>>>
>>>>> On 09/26/2013 02:27 AM, mikhail cherkasov wrote:
>>>>>> a new webrev: 
>>>>>> http://cr.openjdk.java.net/~mcherkas/8020688/webrev.01/
>>>>>> <http://cr.openjdk.java.net/%7Emcherkas/8020688/webrev.01/>
>>>>>> no changes, I've turned off laptop before the webrev upload was
>>>>>> complete, so
>>>>>> the first could be corrupted.
>>>>>>
>>>>>> On 25.09.2013 23:29, mikhail cherkasov wrote:
>>>>>>> Hi all,
>>>>>>>
>>>>>>> Could you please review the fix for the following bug:
>>>>>>> 8020688: broken links in documentation at
>>>>>>> http://docs.oracle.com/javase/6/docs/api/index.
>>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8020688
>>>>>>> The webrev: http://cr.openjdk.java.net/~mcherkas/8020688/webrev.00/
>>>>>>> <http://cr.openjdk.java.net/%7Emcherkas/8020688/webrev.00/>
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Mikhail.
>>>>>>
>>>>
>>