<Swing Dev> [9] Review Request: 8029196 Focus border of JButton.buttonType=roundRect is cut off

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Wed Apr 2 08:05:27 UTC 2014


   The fix looks good for me.

   Thanks,
   Alexandr.

On 4/1/2014 4:53 PM, Sergey Bylokhov wrote:
> On 4/1/14 4:33 PM, Petr Pchelko wrote:
>> Hello, Sergey.
>>
>> Does the fix work for retina thin focuses and non-retina thick?
> yes, it works in both cases.
>>
>> With best regards. Petr.
>>
>> On 01.04.2014, at 15:46, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> 
>> wrote:
>>
>>> Hello.
>>> Please review the fix for jdk 9.
>>> JRS draws all component in specified bounds, but if a component is 
>>> in focus, the frame of focus can exceed the limit of the specified 
>>> bounds.
>>> The focusable components take this into account in the insets, but 
>>> we cut the focus anyway, because we create the buffer image in 
>>> bounds size.
>>> In the fix this image was increased by the focus size in each 
>>> direction.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8029196
>>> Webrev can be found at: 
>>> http://cr.openjdk.java.net/~serb/8029196/webrev.00
>>>
>>> -- 
>>> Best regards, Sergey.
>>>
>
>




More information about the swing-dev mailing list