<Swing Dev> [9] Review Request for 8039074: tidy warnings cleanup for javax.swing
Petr Pchelko
petr.pchelko at oracle.com
Wed Apr 2 14:07:01 UTC 2014
Hello, Alexander.
The second version of the fix looks good to me.
With best regards. Petr.
On 02.04.2014, at 18:04, alexander stepanov <alexander.v.stepanov at oracle.com> wrote:
> Please find the updated webrev here:
> http://cr.openjdk.java.net/~yan/8039074/webrev.01/
>
> On 02.04.2014 17:25, Petr Pchelko wrote:
>>>> src/share/classes/javax/swing/RowSorter.java - I assume the change's that you's changed the minus symbol? It's not clear from the webrev..
>>> Yes, you can see that using the 'patch' link for webrev, e.g.:
>>> http://cr.openjdk.java.net/~yan/8039074/webrev.00/src/share/classes/javax/swing/RowSorter.java.patch
>> Thank you.
>>
>>> With respect to summaries - they could be added easily; please let me know if the following summaries are suitable:
>>> "painters for SynthPainter methods" - for plaf/synth/doc-files/synthFileFormat.html
>>> "nimbus primary colors" and "nimbus secondary colors" for plaf/nimbus/doc-files/properties.html
>> That would be good I suppose. Starting with the capital letter would be even better.
>>
>> With best regards. Petr.
>>
>> On 02.04.2014, at 17:22, alexander stepanov <alexander.v.stepanov at oracle.com> wrote:
>>
>>> Hello Petr,
>>>
>>>> src/share/classes/javax/swing/RowSorter.java - I assume the change's that you's changed the minus symbol? It's not clear from the webrev..
>>> Yes, you can see that using the 'patch' link for webrev, e.g.:
>>> http://cr.openjdk.java.net/~yan/8039074/webrev.00/src/share/classes/javax/swing/RowSorter.java.patch
>>>
>>>> "summaTy" - typo
>>> Sorry, you are right, I have to correct that
>>>
>>> With respect to summaries - they could be added easily; please let me know if the following summaries are suitable:
>>> "painters for SynthPainter methods" - for plaf/synth/doc-files/synthFileFormat.html
>>> "nimbus primary colors" and "nimbus secondary colors" for plaf/nimbus/doc-files/properties.html
>>>
>>> Thanks.
>>>
>>> Regards,
>>> Alexander
>>>
>>> On 02.04.2014 16:43, Petr Pchelko wrote:
>>>> Hello, Alexander.
>>>>
>>>> src/share/classes/javax/swing/RowSorter.java - I assume the change's that you's changed the minus symbol? It's not clear from the webrev..
>>>>
>>>> src/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html - line 89 - "summaTy" - typo. Also, why don't you add a real summary for the table?
>>>>
>>>> src/share/classes/javax/swing/plaf/synth/doc-files/synthFileFormat.html - again, why don't you add a real summary?
>>>>
>>>> With best regards. Petr.
>>>>
>>>> On 02.04.2014, at 16:35, alexander stepanov <alexander.v.stepanov at oracle.com> wrote:
>>>>
>>>>> Hello,
>>>>>
>>>>> Could you please review the fix for the following bug:
>>>>> https://bugs.openjdk.java.net/browse/JDK-8039074
>>>>>
>>>>> Webrev corresponding:
>>>>> http://cr.openjdk.java.net/~yan/8039074/webrev.00/
>>>>>
>>>>> Just a minor cleanup of javadoc to avoid tidy warnings; no other code affected.
>>>>>
>>>>> Thanks.
>
More information about the swing-dev
mailing list