<Swing Dev> Review Request for 8039966: fix doclint block tag issues in swing filechooser and colorchooser classes

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Mon Apr 21 09:49:03 UTC 2014


  The fix looks good for me.

   Thanks,
   Alexandr.


On 4/18/2014 2:57 AM, Steve Sides wrote:
> Hello,
>
> Could you please review the fix for the following bug:
>   https://bugs.openjdk.java.net/browse/JDK-8039966
>
> Webrev corresponding:
>   http://cr.openjdk.java.net/~ssides/8039966/8039966.4/
>
> This addresses missing @parm and @return block tags in javadoc for 
> javax/swing/colorchooser and filechooser classes as noted by doclint.
>
> It does not address methods which are missing javadoc comments 
> completely.
>
> You may want to check the wording of @param for 
> (un)installChooserPanel(). The original seemed a little incorrect to me.
>
> thanks,
>
> -steve
>




More information about the swing-dev mailing list