<Swing Dev> [9] Review Request: 7124250 [macosx] JOptionPane dialogs show wrong icons

[Petr Pchelko]

Hello, AWT Team.

Friendly reminder)

With best regards. Petr.

On 02.04.2014, at 19:02, Petr Pchelko <petr.pchelko at oracle.com> wrote:

> Hello, AWT team.
> 
> Please review a step 1 fix for the issue:
> https://bugs.openjdk.java.net/browse/JDK-7124250
> The fix is here:
> http://cr.openjdk.java.net/~pchelko/9/7124250/webrev/
> 
> In case Java is not installed we've requested an icon that Finder would've used for the folder where the java executable is located. 
> I have no idea why this was done, I've tested this fix with 10.8 and 10.9, Oracle JDK and OpenJDK, with simple apps, applets, JavaWS and bundled apps.
> I've run Netbeans and Idea on top of the JDK with the fix and could not find any regressions, so I propose to remove the suspicious code. 
> 
> After this is fixed I'll file a new bug against the test, because it is wrong - it does not take into account that the OpenJDK and OracleJDK icons are different, 
> also golden images should be updated.
> 
> With best regards. Petr.