<Swing Dev> <AWT Dev> [9] Review Request: 7124250 [macosx] JOptionPane dialogs show wrong icons

[Sergey Bylokhov]

Hi, Petr.
The fix looks good.

On 4/23/14 8:58 PM, Petr Pchelko wrote:
> Hello, Leonid.
>
>> I see you've removed a call to AquaUtils.getCImageCreator().createImageOfFile(path, height, width). What was the original purpose of that call? What icon it is used to return?
> This returned the icon of a folder where java executable is located! So, normally this retuned a folder icon. So there was a strange situation: if java is installed on the system or bundled into .app we use one icon, if java is located somewhere else (like in build/images) we use another icon.
>
> We do not know the original purpose of this code, because it was written before the beginning of macosx port. But, as I’ve written, I’ve tested all possible combinations of JDK/OSX version/Bundling/Webstart and all looks correct, because we always use the icon from the Dock.
>
> With best regards. Petr.
>
> On Apr 23, 2014, at 7:46 PM, Leonid Romanov <leonid.romanov at oracle.com> wrote:
>
>> Hello,
>> I see you've removed a call to AquaUtils.getCImageCreator().createImageOfFile(path, height, width). What was the original purpose of that call? What icon it is used to return?
>>
>> On 4/23/2014 18:26, Petr Pchelko wrote:
>>> Hello, AWT Team.
>>>
>>> Friendly reminder)
>>>
>>> With best regards. Petr.
>>>
>>> On 02.04.2014, at 19:02, Petr Pchelko <petr.pchelko at oracle.com> wrote:
>>>
>>>> Hello, AWT team.
>>>>
>>>> Please review a step 1 fix for the issue:
>>>> https://bugs.openjdk.java.net/browse/JDK-7124250
>>>> The fix is here:
>>>> http://cr.openjdk.java.net/~pchelko/9/7124250/webrev/
>>>>
>>>> In case Java is not installed we've requested an icon that Finder would've used for the folder where the java executable is located.
>>>> I have no idea why this was done, I've tested this fix with 10.8 and 10.9, Oracle JDK and OpenJDK, with simple apps, applets, JavaWS and bundled apps.
>>>> I've run Netbeans and Idea on top of the JDK with the fix and could not find any regressions, so I propose to remove the suspicious code.
>>>>
>>>> After this is fixed I'll file a new bug against the test, because it is wrong - it does not take into account that the OpenJDK and OracleJDK icons are different,
>>>> also golden images should be updated.
>>>>
>>>> With best regards. Petr.


-- 
Best regards, Sergey.