<Swing Dev> Replace concat String to append in StringBuilder parameters

[Wang Weijun]

Hi Otávio

I see TABs in the first page of sun_security.diff, too long line in javax_security.diff.

Also, it's unfortunate that you will need to rename the file names to the new style with modules. See http://cr.openjdk.java.net/~chegar/docs/portingScript.html for how to do this.

I can create webrev page(s) for you on cr.openjdk.java.net. Please tell me if you want a big one or one for each diff.

I see no bug id. If none, I can create one for you.

Thanks
Max

On Aug 20, 2014, at 9:05, Otávio Gonçalves de Santana <otaviojava at java.net> wrote:

> Thank you Sergey.
> https://dl.dropboxusercontent.com/u/16109193/open_jdk/string_builder_concat_7.zip
> 
> 
> On Tue, Aug 19, 2014 at 12:32 PM, Sergey Bylokhov <
> Sergey.Bylokhov at oracle.com> wrote:
> 
>> Hi Otávio,
>> The new alignment in DataLine.java/JColorChooser.java looks strange.
>> Wrong change in BasicTableUI.java:
>> -                    plainStr.deleteCharAt(plainStr.length() -
>> 1).append("\n");
>> +                    plainStr.deleteCharAt(plainStr.length() -
>> 1).append('\t');
>> 
>> 
>> On 13.08.2014 3:01, Otávio Gonçalves de Santana wrote:
>> 
>>> Thank you Roger.
>>> Done
>>> https://dl.dropboxusercontent.com/u/16109193/open_jdk/
>>> string_builder_concat_6.zip
>>> 
>>> 
>>> On Tue, Aug 12, 2014 at 10:15 AM, roger riggs <roger.riggs at oracle.com>
>>> wrote:
>>> 
>>> fyi,
>>>> 
>>>> There's a Perl script normalizer.pl that detects/fixes most of the
>>>> simple
>>>> tab/white space issues.
>>>> The script is in the <repo>/make/scripts/normalizer.pl
>>>> 
>>>> Roger
>>>> 
>>>> 
>>>> On 8/12/2014 3:48 AM, Andrej Golovnin wrote:
>>>> 
>>>> Hi Otávio,
>>>>> 
>>>>> I think you should fix the indentation in a lot of classes. You use the
>>>>> tab-character for the indentation. As far as I know we should use the
>>>>> space
>>>>> character for the indentation in the JDK sources (Oracle devs feel free
>>>>> to
>>>>> correct me if I'm wrong. And it would be really nice if the style guide
>>>>> for
>>>>> the source code would be a part of the JDK repository. So we don't need
>>>>> to
>>>>> search for it on the internet/wiki. Just clone the repository, read the
>>>>> style guide and follow it. :-) ). Here is the not complete list of
>>>>> classes
>>>>> where you used the tab-character for the indentation:
>>>>> 
>>>>> src/share/classes/com/sun/crypto/provider/OAEPParameters.java
>>>>> src/share/classes/java/lang/management/MemoryUsage.java
>>>>> src/share/classes/java/security/KeyStore.java
>>>>> src/share/classes/java/security/PermissionCollection.java
>>>>> src/share/classes/java/security/ProtectionDomain.java
>>>>> src/share/classes/java/security/cert/CertPath.java
>>>>> src/share/classes/java/security/cert/PKIXCertPathBuilderResult.java
>>>>> src/share/classes/java/security/cert/PKIXParameters.java
>>>>> src/share/classes/java/security/cert/PolicyQualifierInfo.java
>>>>> src/share/classes/java/security/cert/TrustAnchor.java
>>>>> src/share/classes/java/security/cert/X509CertSelector.java
>>>>> src/share/classes/javax/crypto/CryptoPermission.java
>>>>> src/share/classes/javax/management/relation/Role.java
>>>>> 
>>>>> 
>>>>> In src/share/classes/com/sun/jmx/snmp/IPAcl/Parser.jj in the line 423 a
>>>>> dot
>>>>> is missed before append:
>>>>> 
>>>>> 423   {jjtn000.name.append( '.')append(t.image); }
>>>>> 
>>>>> Best regards,
>>>>> Andrej Golovnin
>>>>> 
>>>>> 
>>>> 
>>> 
>> 
>> --
>> Best regards, Sergey.
>> 
>> 
> 
> 
> -- 
> Otávio Gonçalves de Santana
> 
> blog:     http://otaviosantana.blogspot.com.br/
> twitter: http://twitter.com/otaviojava
> site:     *http://about.me/otaviojava <http://about.me/otaviojava>*
> 55 (11) 98255-3513
> <sun_tools.diff><sun_security.diff><sun_net.diff><sun_management.diff><sun_launcher.diff><sun_font.diff><javax_swing.diff><javax_sound.diff><javax_security.diff><javax_naming.diff><javax_crypto.diff><javax_,anagement.diff><java_util.diff><java_text.diff><java_security.diff><java_rmi.diff><java_lang.diff><com_sun.diff>