<Swing Dev> [9] Review request for 8066142 closed/javax/swing/JComboBox/4212498/bug4212498.java:Edit the value in the text field and then press the tab key, the number don't increase

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Mon Dec 1 16:45:52 UTC 2014


Hi, Alexander.
The fix looks fine. I assume that tests from 8057893 and 8019180 are passed.

On 01.12.2014 17:17, Alexander Scherbatiy wrote:
>
> Hello,
>
> Could you review the fix:
>   bug: https://bugs.openjdk.java.net/browse/JDK-8066142
>   webrev: http://cr.openjdk.java.net/~alexsch/8066142/webrev.00
>
>   This is a regression from the fix 8057893.
>   The BasicComboBoxUI.focusLost() uses combobox editor  as the 
> ActionEvent sources.
>   The JTextField uses the combobox editor componenr as the ActionEvent 
> sources.
>
>   It seems both JComboBox editor and editor component can be used as 
> an ActionEvent source.
>
>   The fix compares the event source with both combobox editor and 
> combobox editor component.
>
> Thanks,
> Alexandr.
>


-- 
Best regards, Sergey.




More information about the swing-dev mailing list