<Swing Dev> [9] Review Request: 7180976 Pending String deadlocks UIDefaults

Alexander Zvegintsev alexander.zvegintsev at oracle.com
Wed Dec 24 13:07:16 UTC 2014


Hi Sergey,

the fix looks good to me.

Thanks,

Alexander.

On 12/24/2014 03:57 PM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk 9.
> In the JDK-6727661 and JDK-6727662 the  code : "= new 
> String("Pending")" was changed to = "Pending".
> This object is used as a marker when  we start initialization of 
> LazyValue.
> "Pending" in the test and "Pending" in the UIDefaults are pointed to 
> the same object, so the loop in UIDefaults.getFromHashtable() will hang.
> This flag was added in the JDK-4101618 and it does not seem the string 
> type was necessary, so I change it to the simple object, to prevent 
> similar regression in the future
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-7180976
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/7180976/webrev.00
>




More information about the swing-dev mailing list