<Swing Dev> JDK 9 RFR of JDK-8033908: Fix serial lint warnings in com.sun.java.swing.plaf

[Sergey Bylokhov]

Interesting that some of these classes are not Serializable like 
DefaultTreeCellEditor, but have transient fields and 
read/writeObject[1]. Looks like such typos are a good candidate for the 
new lint warning.

[1] https://bugs.openjdk.java.net/browse/JDK-6521727

On 10.03.2014 15:05, Sergey Bylokhov wrote:
> Hi, Joe.
> The fix looks good to me.
>
> On 10.03.2014 10:55, Joe Darcy wrote:
>> Hello,
>>
>> I've adjusted the patch based on changes to the client repo in the 
>> interim:
>>
>>     http://cr.openjdk.java.net/~darcy/8033908.1/
>>
>> Please review.
>>
>> Thanks,
>>
>> -Joe
>>
>> On 02/07/2014 11:53 AM, Joe Darcy wrote:
>>> On 02/07/2014 01:33 AM, Alan Bateman wrote:
>>>> On 07/02/2014 07:53, Joe Darcy wrote:
>>>>> Hello,
>>>>>
>>>>> Please review the webrev to address
>>>>>
>>>>>     JDK-8033908: Fix serial lint warnings in com.sun.java.swing.plaf
>>>>>     http://cr.openjdk.java.net/~darcy/8033908.0/
>>>> This looks fine although for cases where you comment that the 
>>>> supertypes aren't serial compatible across versions then I didn't 
>>>> check that the supertypes document it (I assume they do).
>>>>
>>>
>>> Right, the supertypes in question are generally those covered in
>>>
>>>     8032627: Add @SuppressWarnings("serial") to appropriate 
>>> javax.swing classes
>>>
>>> which are the Swing type which say "I'm serializable on the same 
>>> version, but not across versions." Some of the types in question are 
>>> subtypes of types in com.sun.* which directly document this 
>>> constraint too.
>>>
>>> Thanks for the review,
>>>
>>> -Joe
>>>
>>
>
>


-- 
Best regards, Sergey.