<Swing Dev> [9] Review Request: 8047025 Fix raw and unchecked lint warnings in generated nimbus files

Phil Race philip.race at oracle.com
Mon Jul 7 21:12:37 UTC 2014


Looks ok to me.
The simplest way to test nimbus is to run the "swingset2.jar" demo, and
select "Nimbus" from the L&F drop down menu, then go through the various 
tabs
in the demo. That should exercise all the commonly used elements of Nimbus.
Note that SwingSet2 is in the 'closed' sources so if you don't build 
those regularly
pick up Swingset from a promoted build.

-phil.

On 7/7/2014 1:48 PM, Stuart Marks wrote:
> Hi Henry,
>
> Thanks for taking a look at this.
>
> I'd appreciate additional review from one of the Swing developers, 
> particularly about the issue of testing Nimbus.
>
> s'marks
>
> On 7/2/14 4:47 PM, Henry Jen wrote:
>> Looks good to me.
>>
>> Cheers,
>> Henry
>>
>>
>> On 07/02/2014 03:31 PM, Stuart Marks wrote:
>>> Hi all,
>>>
>>> Please review this change for 8047025, "Fix raw and unchecked lint
>>> warnings in generated nimbus files."
>>>
>>> Webrev:
>>>
>>> http://cr.openjdk.java.net/~smarks/reviews/8047025/webrev.0/
>>>
>>> Bug:
>>>
>>>      https://bugs.openjdk.java.net/browse/JDK-8047025
>>>
>>> Although this change modifies only a few lines of template files, it
>>> removes 31 raw and unchecked lint warnings.
>>>
>>> I've done a build with the changes in place, and I've also run 
>>> SwingSet2
>>> and switched it to the Nimbus L&F and it looked fine to me. Please let
>>> me know if I should do additional testing.
>>>
>>> Thanks,
>>>
>>> s'marks




More information about the swing-dev mailing list