<Swing Dev> [9] Review Request: JDK-8043968: Fix doclint warnings from javax.swing.plaf.basic package, 1 of 7

Petr Pchelko petr.pchelko at oracle.com
Wed Jul 9 12:22:09 UTC 2014


Hello, Andrei.

BasicButtonListener.checkOpacity - I think the doc is to detailed. You basically write how the method works and it prevents us prom changing it in the future. Also it's overridden in Metal L&F and it does a different thing there. Could you please come up with some less detailed description.

BasicComboBoxRenderer - the constructor doc is too detailed.

BasicGraphicsUtils:55 - type ethecd

BasicHTML:188 - wrong indentation

BasicPopupMenuUI:225 - dot needed.

BasicSeparatorUI:49 - dot needed.

With best regards. Petr.

On 09 июля 2014 г., at 16:02, andrei.eremeev <andrei.eremeev at oracle.com> wrote:

> Hi Swing team,
> 
> Please, review the fix for the issue:
> https://bugs.openjdk.java.net/browse/JDK-8043968
> 
> The fix is available at:
> http://cr.openjdk.java.net/~yan/8043968/
> 
> Andrei




More information about the swing-dev mailing list