<Swing Dev> Review Request for 8040901: fix doclint block tag issues in swing/event classes

Steve Sides steve.sides at oracle.com
Wed Jun 4 19:09:01 UTC 2014


..after very long pause....
http://cr.openjdk.java.net/~ssides/8040901/8040901.2/

-steve

On 5/15/2014 8:41 AM, Alexander Scherbatiy wrote:
> src/share/classes/javax/swing/event/TableColumnModelEvent.java
> -------------------------
> -    /** Returns the fromIndex.  Valid for removed or moved events */
> +    /**
> +     * Returns the fromIndex.  Valid for removed or moved events
> +     *
> +     * @return int value for index from which the column was moved
> +     */
> -------------------------
>
> Return statement should also mention that  column can be removed.
>
>
> Thanks,
> Alexandr.
>
> On 5/13/2014 11:56 PM, Steve Sides wrote:
>> no response..posting again...maybe 3rd times a charm :) ....
>>
>> Hello,
>>
>> Could you please review the fix for the following bug:
>>   https://bugs.openjdk.java.net/browse/JDK-8040901
>>
>> Webrev corresponding:
>> http://cr.openjdk.java.net/~ssides/8040901/
>>
>> This addresses missing @param and @return block tags in javadoc for 
>> javax/swing/event classes as noted by doclint.
>> There are also a handful of formatting updates, fixes for typos, and
>> copyright updates for the edited files.
>>
>> It does not address methods which are missing javadoc comments 
>> completely.
>>
>>
>> thanks,
>>
>> -steve
>>
>




More information about the swing-dev mailing list