<Swing Dev> RFR: 8046485: Add missing @since tag under javax.swing.*

Phil Race philip.race at oracle.com
Wed Jun 18 17:44:30 UTC 2014


Hello,

You say "under" javax.swing but you don't seem to be touching
any sub-packages. I notice there is at least one @since 1.7 you
added to the Painter interface - so they aren't all 1.2 - and yet
you didn't add the @since 1.7 to the sole class that implements
Painter - perhaps because its in a sub-package.

Also note that whilst @since 1.2 is strictly correct in terms of Java SE
but Swing was initially an unbundled library - somewhat analagous
to Java FX 2.x, and ran on JDK 1.1.x

-phil.

On 6/18/2014 9:16 AM, Henry Jen wrote:
> Thanks, Alexander.
>
> Cheers,
> Henry
>
> On 06/18/2014 03:44 AM, Alexander Scherbatiy wrote:
>>
>>    The fix looks good for me.
>>
>>    Thanks,
>>    Alexandr.
>>
>> On 6/11/2014 4:00 AM, Henry Jen wrote:
>>> Hi,
>>>
>>> Please review a trivial webrev that provides missing @since tag for
>>> elements under javax.swing,
>>>
>>> Essentially it's simply add @since 1.2 for all
>>> classes/interfaces/exception that are missing @since tag, as JDK 1.2
>>> package.html has @since tag but was removed in 1.3.
>>>
>>> The @since tag is added to *.java instead of package.html so that we
>>> can have javac report javadoc via
>>> javax.lang.model.util.Elements.getDocComment(Element c).
>>>
>>> http://cr.openjdk.java.net/~henryjen/jdk9/8046485/0/webrev/
>>>
>>> Cheers,
>>> Henry
>>




More information about the swing-dev mailing list