<Swing Dev> [9] Review Request: JDK-8046446, , Fix doclint warnings in javax.swing.text.html package

andrei.eremeev andrei.eremeev at oracle.com
Thu Jun 19 12:25:21 UTC 2014


Hi,

I have fixed Petr's remarks.
http://cr.openjdk.java.net/~yan/8046446/webrev.01/

Andrei

On 06/18/2014 02:39 PM, Petr Pchelko wrote:
> Hello, Andrei.
>
> HTMLEditorKit.java:276 - the beginning of the description if not aligned
> Actually all the HTMLEditorKit has alignment issues. For example lines 1754-1764.
> Why some parameter descriptions are aligned and others are not?
> I think it's better to align the beginnings of the parameter descriptions for better readability.
>
> MinimalHTMLWriter:290 why did you add the full class name here while it's short in all other files?
> Same in all the rest of the file and in StyleSheet class. This is not a big deal, but it's inconsistent.
>
> Stylesheet: 535 - the line's too long
>
> With best regards. Petr.
>
>
> On 11 июня 2014 г., at 15:30, andrei.eremeev <andrei.eremeev at oracle.com> wrote:
>
>> Hi Swing team,
>>
>> Please, review the fix for the issue:
>> https://bugs.openjdk.java.net/browse/JDK-8046446
>>
>> The fix is available at:
>> http://cr.openjdk.java.net/~yan/8046446/webrev.00
>>
>> Andrei
>>
>>




More information about the swing-dev mailing list