<Swing Dev> [9] Review Request: JDK-8046446 Fix doclint warnings in javax.swing.text.html.parser package

Petr Pchelko petr.pchelko at oracle.com
Thu Jun 19 12:31:30 UTC 2014


Thank you. The version looks good.

With best regards. Petr.

On 19 июня 2014 г., at 16:26, andrei.eremeev <andrei.eremeev at oracle.com> wrote:

> Hi,
> 
> I have fixed Petr's remarks.
> 
> http://cr.openjdk.java.net/~yan/8046895/webrev.01/
> 
> Andrei
> 
> On 06/18/2014 04:13 PM, Petr Pchelko wrote:
>> Please ignore my comment about alignment, you are actually doing that in a right way, my bad.
>> 
>> With best regards. Petr.
>> 
>> On 18 июня 2014 г., at 16:06, Petr Pchelko <petr.pchelko at oracle.com> wrote:
>> 
>>> Hello, Andrei.
>>> 
>>> TagElement: 99 Could you please add an empty line before @return as everywhere else.
>>> 
>>> Also could could you please fix the alignment of the beginnings of the parameter descriptions.
>>> 
>>> Thank you.
>>> With best regards. Petr.
>>> 
>>> On 16 июня 2014 г., at 16:07, andrei.eremeev <andrei.eremeev at oracle.com> wrote:
>>> 
>>>> Hi Swing team,
>>>> 
>>>> Please, review the fix for the issue:
>>>> https://bugs.openjdk.java.net/browse/JDK-8046895
>>>> 
>>>> The fix is available at:
>>>> http://cr.openjdk.java.net/~yan/8046895/webrev.00/
>>>> 
>>>> Andrei
> 




More information about the swing-dev mailing list