<Swing Dev> Review Request for 8042284: Add block tags for @return and @param to swing plaf classes

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Thu Jun 19 13:11:26 UTC 2014


-----------------
src/share/classes/javax/swing/plaf/TreeUI.java
+      * @return true if {@code tree} if is being edited
        */
      public abstract boolean isEditing(JTree tree);
-----------------
The 'if' word is doubled in the text "@return true if {@code tree} if is 
being edited"



I think you can use the current javadoc in the return tag for the method 
"getPathBounds(JTree tree, TreePath path)" even something is not correct.
Both versions will be fixed in the separate issue together.

Thanks,
Alexandr.


On 6/5/2014 10:32 PM, Steve Sides wrote:
> Sorry, I had introduced a doclint error on line 59 of TextUI.java 
> (wrong param name, 'b' instead of 'bias').
> This corrects that:
> http://cr.openjdk.java.net/~ssides/8042284/8042284.2/
>
> -steve
>
> On 6/5/2014 10:34 AM, Steve Sides wrote:
>> ------------------------------------------------------------------------
>> Hello,
>>
>> Could you please review the fix for the following bug:
>> https://bugs.openjdk.java.net/browse/JDK-8042284
>>
>> Webrev corresponding:
>> http://cr.openjdk.java.net/~ssides/8042284/8042284.1  <http://cr.openjdk.java.net/%7Essides/80042284/8042284.1>
>>
>> This addresses missing @parm and @return block tags in javadoc for
>> javax/swing/plaf classes as noted by doclint.
>>
>> It does not address methods which are missing javadoc comment altogether,
>> of which there are several.
>>
>>
>> thanks,
>>
>> -steve
>>
>




More information about the swing-dev mailing list