<Swing Dev> Review Request for 8044281: Fix doclint warnings (missing javadoc tags) in javax.swing.table

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Wed Jun 25 13:19:18 UTC 2014


   The fix looks good to me.

   Thanks,
   Alexandr.

On 6/25/2014 2:16 AM, Rocky Sloan wrote:
> One change to original webrev (Remove extraneous text after a @param 
> tag).
> http://cr.openjdk.java.net/~yan/8044281/webrev.01/
>
> Thanks,
> Rocky
>
> On 6/19/2014 7:50 AM, Alexander Scherbatiy wrote:
>>
>> +++ new/src/share/classes/javax/swing/table/DefaultTableModel.java 
>> 2014-06-12 02:25:22.416603643 -0700
>> @@ -335,6 +335,11 @@
>>       *
>>       *  @see #setColumnCount
>>       * @since 1.3
>> +     *
>> +     * @param rowCount  Sets the number of rows in the model. If the 
>> new
>> +     * size is greater than the current size, new rows are added to the
>> +     * end of the model.  If the new size is less than the current 
>> size,
>> +     * all rows at index <code>rowCount</code> and greater are 
>> discarded.
>>       */
>>
>> I think it is not necessary to copy the same javadoc for the param tag.
>> "number of rows in the model" should be enough.
>> It always possible to read the method javadoc for more detailed 
>> description.
>>
>> Thanks,
>> Alexandr.
>>
>>
>> On 6/17/2014 1:01 AM, Rocky Sloan wrote:
>>> Hello,
>>>
>>> Could you please review the fix for the following bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8044281
>>>
>>> Webrev corresponding:
>>> http://cr.openjdk.java.net/~yan/8044281/webrev.00/
>>>
>>> Add missing @return and @param javadoc tags in javax.swing.table 
>>> classes
>>> to fix doclint warnings.
>>>
>>> Thanks,
>>>
>>> - Rocky
>>>
>>
>




More information about the swing-dev mailing list