<Swing Dev> [9] Review request for 8048506: [macosx] javax.swing.PopupFactory issue with null owner

[Alexander Scherbatiy]

   The fix looks good to me.

  Thanks,
  Alexandr.

On 6/30/2014 1:17 PM, dmitry markov wrote:
> Hello, Petr.
>
> Thank you for review.
> Please find a new version here: 
> http://cr.openjdk.java.net/~dmarkov/8048506/jdk9/webrev.01/
>
> If you do not mind, I would like to stay the anonymous inner class as 
> is to avoid test's modification during backport, since jdk7 does not 
> support lambda.
>
> Thanks,
> Dmitry
> On 30/06/2014 12:23, Petr Pchelko wrote:
>> Hello, Dmitry.
>>
>> Why are you making the test mac-specific? Why should it fail on other 
>> platforms?
>> Could you please replace the anonymous inner class with a method 
>> reference in the test.
>>
>> With best regards. Petr.
>>
>> On 30 июня 2014 г., at 11:19, dmitry markov 
>> <dmitry.markov at oracle.com> wrote:
>>
>>> Hello,
>>>
>>> Could you review the fix for jdk9, please?
>>>
>>>     bug: https://bugs.openjdk.java.net/browse/JDK-8048506
>>>     webrev: http://cr.openjdk.java.net/~dmarkov/8048506/jdk9/webrev.00/
>>>
>>> Problem description: this is regression caused by the changes for 
>>> JDK-8042465
>>> Fix: added null check to PopupFactory.getPopup() method to avoid NPE 
>>> when getPopup() is invoked with null-owner argument.
>>>
>>> Thanks,
>>> Dmitry
>