<Swing Dev> [9] Review Request: JDK-8046434: Fix doclint warnings from javax.swing.plaf.metal package
andrei.eremeev
andrei.eremeev at oracle.com
Mon Jun 30 10:38:39 UTC 2014
Hi,
Second iteration: http://cr.openjdk.java.net/~yan/8046434/webrev.01/
Fixes:
1. the typo
2. reverted javadoc about "obsolete classes" and created new issue
<https://bugs.openjdk.java.net/browse/JDK-8048702>.
Andrei
On 06/26/2014 05:01 PM, Alexander Scherbatiy wrote:
>
>
> new/src/share/classes/javax/swing/plaf/metal/MetalFileChooserUI.java
> - // Obsolete class, not used in this version.
> + /**
> + * Obsolete class, not used in this version.
> + */
>
> Adding such javadoc may require a CCC request.
>
> Could you use a simple description for obsolete classes and create a
> new issue to deprecate them?
>
> Thanks,
> Alexandr.
>
> On 6/26/2014 4:41 PM, andrei.eremeev wrote:
>> Hi Alexander,
>>
>> This fix of the type is small. Does it mean the webrev is approved?
>> Can I push without making new webrev if I fix the type?
>>
>> Andrei
>>
>> On 06/26/2014 01:05 PM, Alexander Scherbatiy wrote:
>>>
>>> There is a small typo:
>>> src/share/classes/javax/swing/plaf/metal/MetalTabbedPaneUI.java
>>> + /**
>>> + * The color ot tab's background.
>>> + */
>>> protected Color tabAreaBackground;
>>>
>>>
>>> Thanks,
>>> Alexandr.
>>>
>>> On 6/25/2014 6:13 PM, andrei.eremeev wrote:
>>>> Hi Swing team,
>>>>
>>>> Please, review the fix for the issue:
>>>> https://bugs.openjdk.java.net/browse/JDK-8046434
>>>>
>>>> The fix is available at:
>>>> http://cr.openjdk.java.net/~yan/8046434/webrev.00/
>>>>
>>>> Andrei
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20140630/eb6b2f39/attachment.html>
More information about the swing-dev
mailing list