<Swing Dev> Review request for JDK-8042089: Fix doclint warnings from javax.swing.tree and javax.swing.undo packages

Dmitriy Ermashov dmitriy.ermashov at oracle.com
Wed May 14 12:59:17 UTC 2014


Hi,

Please review the changeset for:
https://bugs.openjdk.java.net/browse/JDK-8042089

Webrev is here:
http://cr.openjdk.java.net/~yan/8042089/webrev.01/

It is a fix for doclint warnings in javadoc. Added tags @param and 
@return to methods.

Last changes:
1. Changed params description in 
DefaultTreeSelectionModel.notifyPathChange() method

Thanks,
Dima

On 04/30/2014 07:07 PM, Alexander Scherbatiy wrote:
> src/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java
> ---------------------------------
> +     *
> +     * @param changedPaths      the vector of the changed patches
> +     * @param oldLeadSelection  the old selection index
>       */
> ---------------------------------
>
> The oldLeadSelection parameter has TreePath  type and the index 
> usually relates to an integer value.
>
> Thanks,
> Alexandr.
>
>
> On 4/29/2014 1:29 PM, Dmitriy Ermashov wrote:
>> Hi,
>>
>> Please review the changeset for:
>> https://bugs.openjdk.java.net/browse/JDK-8042089
>>
>> Webrev is here:
>> http://cr.openjdk.java.net/~yan/8042089/webrev.00/
>>
>> For Alexander Potochkin and Alexandr Scherbatiy:
>> Guys, could you add me to subscription list swing-dev at openjdk.java.net?
>>
>




More information about the swing-dev mailing list