<Swing Dev> [9] Review Request: 8031485 [macosx] Combo box consuming escape key events

Petr Pchelko petr.pchelko at oracle.com
Tue May 20 17:17:46 UTC 2014


Hello, 

Could I please get a second review on this issue?
>> Please review the fix for the issue:
>> https://bugs.openjdk.java.net/browse/JDK-8031485
>> The fix is available at:
>> http://cr.openjdk.java.net/~pchelko/9/8031485/webrev.00/

Thanks. With best regards. Petr.

On May 14, 2014, at 7:00 PM, Alexander Scherbatiy <alexandr.scherbatiy at oracle.com> wrote:

> 
>  The fix looks good for me.
> 
>  Thanks,
>  Alexandr.
> 
> On 5/14/2014 6:13 PM, Petr Pchelko wrote:
>> Hello,
>> 
>> Please review the fix for the issue:
>> https://bugs.openjdk.java.net/browse/JDK-8031485
>> The fix is available at:
>> http://cr.openjdk.java.net/~pchelko/9/8031485/webrev.00/
>> 
>> We should not consume the ESC if the popup is not visible.
>> 
>> Thank you.
>> With best regards. Petr.
> 




More information about the swing-dev mailing list