<Swing Dev> [9] Review request for 8065098 JColorChooser no longer supports drag and drop between two JVM instances

[Alexey Ivanov]

Hi Alexandr,

Although I'm not a reviewer, the fix look good to me.

The fix works with JColorChooserDnDTest and does not cause 
ClassCastException in the test for 8024061. Yet the latter test, 
test/sun/awt/dnd/8024061/bug8024061.java, fails. I propose to remove the 
additional check that data is null, lines 280-282,  from the test.

Regards,
Alexey

On 21.11.2014 13:38, Alexandr Scherbatiy wrote:
>
> Hello,
>
> Could you review the fix:
>   bug: https://bugs.openjdk.java.net/browse/JDK-8065098
>   webrev: http://cr.openjdk.java.net/~alexsch/8065098/webrev.00
>
>   The issue appears after the fix 8024061 Exception thrown when drag 
> and drop between two components is executed quickly.
>   In some way the mime type of the dropped color has 
> javaJVMLocalObjectMimeType on the second JVM.
>
>   The issue should be fixed in JDK 8 as the regression so the easy 
> safe fix that prevents ClassCastException is added.
>   The full fix that includes a proper synchronization between XAWT and 
> EDT threads on Linux can be added later.
>
> Thanks,
> Alexandr.
>