<Swing Dev> [9] Review request for 8058120: Rendering / caret errors with HTMLDocument

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Wed Oct 8 08:29:21 UTC 2014


On 10/8/2014 10:32 AM, dmitry markov wrote:
> Hello,
>
> Any volunteers to review the fix?

Could you give more details about the change:
-------------
-                if (offset > getLength()) {
+                if (offset > (getLength() + 1)) {
                      offset--;
                  }
-------------

Should it depend on the insertInBody value?

Thanks,
Alexandr.

>
> Thanks,
> Dmitry
>
> On 03/10/2014 09:58, dmitry markov wrote:
>> Hello,
>>
>> Friendly reminder... Could anyone review the fix, please?
>>
>> Thanks,
>> Dmitry
>> On 29/09/2014 11:10, dmitry markov wrote:
>>> Hello,
>>>
>>> Could you review the fix for jdk9, please?
>>>
>>>     bug: https://bugs.openjdk.java.net/browse/JDK-8058120
>>>     webrev: http://cr.openjdk.java.net/~dmarkov/8058120/jdk9/webrev.00/
>>>
>>> Problem description: if some text (not wrapped by HTML tags) is 
>>> inserted via insertAfterEnd() method, the text is added directly to 
>>> the body of HTML document. This will cause incorrect representation 
>>> of added fragment.
>>> Fix: it is necessary to detect the insertion of the text to the body 
>>> and wrap the text by p-implied tags.
>>>
>>> Thanks,
>>> Dmitry
>>
>




More information about the swing-dev mailing list