<Swing Dev> [9] Review Request: 8059943 [macosx] Aqua LaF should use BI.TYPE_INT_ARGB_PRE for a better performance

[Alexander Zvegintsev]

Hello Sergey,

The fix looks good to me.

--
Thanks,
Alexander.

On 10/10/2014 02:26 PM, Sergey Bylokhov wrote:
> On 10.10.2014 13:58, Alexander Scherbatiy wrote:
>>
>>   The fix looks good to me.
>>
>>   Is it possible to write an automated test for the fix?
> No, since these images are used internally.
>>
>>   Thanks,
>>   Alexandr.
>>
>> On 10/10/2014 12:28 PM, Sergey Bylokhov wrote:
>>> Hello.
>>> Please review the small fix for jdk 9.
>>> Only TYPE_INT_ARGB_PRE is natively supported on osx in opengl 
>>> pipeline(see OGLBlitLoops.java). Other types with alpha use 
>>> OGLGeneralBlit which convert an image to argb_pre on the fly, this 
>>> hurts a performance.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8059943
>>> Webrev can be found at: 
>>> http://cr.openjdk.java.net/~serb/8059943/webrev.00
>>>
>>
>
>