<Swing Dev> [9] Review request for 8057184 JCK8's api/javax_swing/JDesktopPane/descriptions.html#getset failed with GTKLookAndFeel on Linux and Solaris run v.s. JDK8+

[Alexander Scherbatiy]

On 9/4/2014 4:24 PM, Anton V. Tarasov wrote:
> Hi Alexander,
>
> Looks fine for me, however you could use HashSet instead of ArrayList 
> in order to avoid the check for "contains".
>
  Could you review the updated fix:
   http://cr.openjdk.java.net/~alexsch/8057184/webrev.01

   I changed the ArrayList to LinkedHashSet just to preserve the order 
of added internal frames.
   The javadoc does not require it but it preserves the previous behavior.

   Thanks,
   Alexandr.

> Thanks,
> Anton.
>
> On 04.09.2014 15:29, Alexander Scherbatiy wrote:
>>
>> Hello,
>>
>> Could you review the fix:
>>   bug: https://bugs.openjdk.java.net/browse/JDK-8057184
>>   webrev: http://cr.openjdk.java.net/~alexsch/8057184/webrev.00
>>
>>   The fix skips the same internal frames from the 
>> JDesktopPane.getAllFrames() results.
>>
>> Thanks,
>> Alexandr.
>>
>