<Swing Dev> [9] Review Request for 8056991: Provide OSInfo functionality to regression tests
Yuri Nesterenko
yuri.nesterenko at oracle.com
Mon Sep 8 09:09:39 UTC 2014
Weekly reminder!
Cheers,
-yan
On 09/01/2014 12:44 PM, Yuri Nesterenko wrote:
> Colleagues,
>
> please review this minimal change to fix
> https://bugs.openjdk.java.net/browse/JDK-8056991
>
> http://cr.openjdk.java.net/~yan/8056991/webrev.00
>
> In the webrev there is an example of a test refactored.
>
> We need to clean up regression tests from internal
> dependencies. One of them, dependency on sun.awt.OSInfo.java, a
> standard (however internal) tool to provide a version
> of current OS.
> Here, I'm just copying the file to a test helper directory.
> (1) no swing library class depending on OSInfo will be affected
> (2) no public API change occurs
> A person updating sun.awt.OSInfo in future should, however,
> duplicate changes in this test copy as well which is an ugly
> compromise.
>
> Thanks,
> -yan
More information about the swing-dev
mailing list