<Swing Dev> [9] Review request for 8057770: api/javax_swing/JScrollPane/indexTGF.html#UpdateUI failed with MotifLookAndFeel on all platform

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Tue Sep 9 11:30:58 UTC 2014


The fix looks good to me.

Thanks,
Alexandr.

On 9/9/2014 2:51 PM, Alexander Zvegintsev wrote:
> Hello,
>
> please review the fix
> http://cr.openjdk.java.net/~azvegint/jdk/9/8057770/00/
> for the issue
> https://bugs.openjdk.java.net/browse/JDK-8057770
>
> This  issue
> MotifScrollPaneUI does not override uninstallListeners() method from 
> BasicScrollPaneUI
>
> It has following signature
> protected void uninstallListeners(JScrollPane scrollPane)
> but it should be
> protected void uninstallListeners(JComponent c)
>
> Hence listeners will never be deleted. This type of issues can be 
> avoided by using @Override annotation.
> Same issue fixed in XAWTScrollPaneUI.
>
>
>
>




More information about the swing-dev mailing list