<Swing Dev> [9] Review Request: 6329748 Invalid/old variable name - newModel in setModel method in JTable class

Phil Race philip.race at oracle.com
Tue Sep 23 18:09:37 UTC 2014


looks ok to me

-phil.

On 9/23/2014 10:59 AM, Sergey Bylokhov wrote:
> Hello.
> Any volunteers?
>
> On 18.08.2014 18:18, Sergey Bylokhov wrote:
>> Hello.
>> Please review the small fix for jdk 9.
>> Bug description:
>> Long long time ago all our JTable.set*model methods used newModel as 
>> a parameter.
>> Since then:
>>  - setModel() parameterand at param tag were changed from newModel to 
>> dataModel, but method description and @exception were not updated.
>>  - setColumnModel parameter, @param and @exception tags werechanged 
>> from newModel to columnModel, but method description was not updated.
>>  - setSelectionModel was not updated at all.
>>
>> Plus in the fix I align description of all of these methods to the 
>> one style.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-6329748
>> Webrev can be found at: 
>> http://cr.openjdk.java.net/~serb/6329748/webrev.00
>>
>
>




More information about the swing-dev mailing list